Added a new URL textfield to the GO Video Paragraph. #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URL textfield is used for adding a VideoTool URL, which will be used to render VideoTool videos in the frontend. Removed existing Media field from the paragraph, as it will not be used for now. This is probably a temporary solution, as we would like to integrate VideoTool into the core Media module. But for now this will be sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-293
Description
Added a new URL textfield to the GO Video Paragraph.
The URL textfield is used for adding a VideoTool URL, which will be used to render VideoTool videos in the frontend.
Removed existing Media field from the paragraph, as it will not be used for now.
This is probably a temporary solution, as we would like to integrate VideoTool into the core Media module. But for now this will be sufficient.
Screenshot of the result
Example of a GraphQL query used for fetching an GO Page containing an GO Video paragraph:
Additional comments or questions
As mentioned above, this is not the desired way of implementing VideoTool videos in the GO frontend.
Another task already exist for implementing VideoTool into the Media Core module. When this task has been completed, we will have to implement this into the GO Video Paragraph as well.